I believe one of the most valuable things we can do in code reviews is...


I believe one of the most valuable things we can do in code reviews is improve naming.

"I'm unclear what this variable name means."

"This function's name doesn't seem to match the implementation. It looks like it does x. Can we rename it to x?"
It's far easier to get the naming right when collaborating with the author immediately after they wrote it.

Once code is committed, a poorly named variable or function can be a drag on productivity for years.

So I try my best to fix naming before merge.

View original on X