I typically run the app when reviewing a PR
I typically run the app when reviewing a PR.
Here's why:
✅Helps me see the user experience.
✅Seeing the UX helps me read the code, because it helps me understand what the code does, and why.
✅It gives me ideas for checking the code for edge cases.
✅ Viewing and navigating the code in my editor helps me notice where files are located relative to one another. This helps me catch colocation opportunities.
✅ Running the code allows me to check for edge cases, accessibility, usability, and performance issues.
Concern: "Ain't nobody got time for that".
Reality: Thorough reviews save time. Reviews avoid rework, catch issues early, enforce consistency, and so on.
And ideally I simply run the automated in-browser tests provided with the PR. That takes very little time.
Concern: "I trust my coworkers".
Reality: No one deserves 100% trust. We all make mistakes. And we're all continually striving to improve, together. Good reviews support growth on both sides.