Habit: When I open a PR, I review the diff myself first
Habit: When I open a PR, I review the diff myself first.
I ask:
Is this change well tested?
Are docs necessary?
Any hacks I need to resolve?
Any follow-up tickets I should open?
Do I need to add comments or improve my naming?
Should I split this PR to make it more focused?
Oh forgot one of the most important:
Are there any changes in here that I didn’t intend to commit?