My code review checklist: ✅ Tested ✅ Secure ✅ Robust ✅ Reusable ✅ Accessible...
My code review checklist:
✅ Tested
✅ Secure
✅ Robust
✅ Reusable
✅ Accessible
✅ Performant
✅ Configurable
✅ Documented
I use this as a quick reminder to consider different facets of quality in each code review. That's why it's deliberately short and high level.
Some of these items don't apply to every PR. But that's okay because the list is short.
I use this checklist on myself. I review this list before I open my PR. This helps me avoid wasting other people's time by assuring my work is truly ready for review.
I leave some items off because they're naturally on my mind. For instance, each PR should be readable and maintainable. I find that I don't need a reminder to consider these aspects.
A useful checklist is long enough to help, but short enough that it can be used consistently.