Two code review approaches: 1
Two code review approaches:
1. Pull request
2. Pair/mob programming
My take? I believe in a hybrid model.
Neither is perfect. So we should use both.
Let’s consider the merits of PRs vs pairing/mobbing…
🧵…
PRs
✅ Async. Good for varied schedules
✅ Work and provide feedback at your own pace, using your preferred workflow and tools
✅ Written record
✅ Less intimidating for juniors
❌ Long wait times
❌ Poor quality reviews, especially on big PRs
🧵…
Pairing
✅ Continuous review = No waiting and less rework
✅ 2+ minds = more creative, higher quality
❌ Requires sync’d schedules
❌ Tiring
❌ Pairing with no PR means the team doesn’t get to review changes
❌ Some dislike it for social, autonomy, & workflow reasons
🧵…
Both have tradeoffs. So, how about a mix? 🧐
1. Pair/mob at the start briefly to choose a path.
2. Split and implement.
3. Request feedback along the way as needed.
4. When complete, open a PR and present the PR verbally to the team to foster rapid, candid feedback.
🧵…
To me this hybrid option presents the best of both worlds.
✅ Feedback early and often, as needed.
✅ Avoids overhead of having 2+ people working a problem when there’s a clear path forward.
✅ Allows people to continue to work on their own schedules, processes, editors, etc.
This hybrid approach also mirrors many other industries.
Work as a team and pair early for planning and critical decisions. Work alone when the path is clear.
Flex as needed. 🤓
<end/>