Developers who merely click approve on every pull request aren’t doing their job
Developers who merely click approve on every pull request aren’t doing their job.
They’re a liability.
They squander the opportunity for quality control, learning, and feedback.
Caveat: Some short-sighted managers encourage rubber-stamping pull requests.
Some do so implicitly: “The burn down chart looks bad. We need to speed up.”
Some do so explicitly: “We need to ship this quickly. We don’t have time for reviews.”
In such situations, I still do thorough reviews.
My philosophy: I don’t ask for permission to do my job well.