When a developer responds to every pull request with “looks good to me”, I...
When a developer responds to every pull request with “looks good to me”, I don’t think “wow, you’re easy to work with!” I think “are you too busy to give me a real review with useful feedback?”
If every pull request is approved without comment, something is wrong.
As a manager, if I had a developer who merely clicked approve on each pull request, I said something.
Rubber stamping pull requests creates a liability. Why? Because it eliminates an opportunity for catching issues.
Thoughtful code reviews are a critical part of the job.
Reasons a developer may approve every pull request without comment:
-"My manager doesn't want me to spend time on reviews."
-"I don't care about other people's work."
-"I'm too intimidated/inexperienced to do reviews."
-"I'm too busy."
These are problems worth solving.